-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(BKR-946) update beaker dependency & docs #87
Conversation
Refer to this link for build results (access rights to CI server needed): |
@puppetlabs-jenkins retest this please |
Refer to this link for build results (access rights to CI server needed): |
@puppetlabs-jenkins retest this please |
Refer to this link for build results (access rights to CI server needed): |
@puppetlabs-jenkins retest this please |
Refer to this link for build results (access rights to CI server needed): |
One quibble, the docs say "we've given up on Ruby 1.9" but the required Ruby version must be >= 2.2.5... |
#Upgrading from beaker-rspec 5 to 6 | ||
|
||
In beaker-rspec 6, we've picked up the newest beaker, 3.y. In this release, we've | ||
given up support for Ruby 1.9 and moved to 2.2.5 as our lowest tested version, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're giving up 1.9 can we delete the special-case code in the gemspec too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer to this link for build results (access rights to CI server needed): |
@@ -3,9 +3,6 @@ $:.push File.expand_path("../lib", __FILE__) | |||
require 'rbconfig' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevpl We can delete this too right?
Refer to this link for build results (access rights to CI server needed): |
This change picks up from the branch that we've been testing over the last few weeks and adds documentation & the new Ruby requirement to it.