-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby 3.1/Psych 4 compatibility issues #1753
Comments
To me the biggest questions is why Beaker serializes so much. It feels to me that it's serializing way too much. For example, a logger? A password prompt? Feels to me that they should be excluded from the file but I don't know beaker well enough to say. |
Yeah marshaling the ruby objects to yaml seems... Not ideal. But refactoring that seems like a bit of an endeavor. |
I think #1758 should work until we fix the issue of serializing too much into this file. |
This commit adds the PlatformTagContainer class to the HostsFileParser module so that tests can be re-run. This class was added to the 5.x series in a previous commit [1] but was not added to the 4.x branch. For context see issue [1]: 45f0bf9 [2]: voxpupuli#1753
This commit adds the PlatformTagContainer class to the HostsFileParser module so that tests can be re-run. This class was added to the 5.x series in a previous commit [1] but was not added to the 4.x branch. For context see issue 1753 [2]. [1]: 45f0bf9 [2]: voxpupuli#1753
WIth the work to support ruby 3 a32f4fd permitted classes were enumerated to read from preserved hosts. This list appears to be incomplete when you have configured ssh for a particular preserved hosts: See below for some classes that are preserved on ssh config in the following snippet:
With beaker 4.35.0 and later when beaker attempts to read a hosts file with ssh config preserved it fails becuase the
Logger
andNet::SSH
classes are not permitted to be safe loaded.Would you recommend we add those all to the permitted classes list? Or is there some other way we need to handle this (maybe serializing the ssh config in a different way)?
The text was updated successfully, but these errors were encountered: