(QA-794) make vagrant vm size configurable through beaker #141
Conversation
anodelman
commented
Feb 5, 2014
anodelman
commented
- add support for a vagrant_memsize in the config file
- default to 1024
|
🔴 Test failed. |
|
Yes please :-) |
|
The docs for Vagrant (http://docs.vagrantup.com/v2/virtualbox/configuration.html) have a shorter way of setting memory ( |
|
@anodelman tests are failing |
|
Tests on re-run were green, but didn't report here: http://jenkins-beaker.delivery.puppetlabs.net/job/Beaker%20Specs/97/ |
| @@ -34,7 +34,7 @@ def make_vfile hosts | |||
| @logger.debug "created Vagrantfile for VagrantHost #{host.name}" | |||
| end | |||
| v_file << " c.vm.provider :virtualbox do |vb|\n" | |||
| v_file << " vb.customize [\"modifyvm\", :id, \"--memory\", \"1024\"]\n" | |||
| v_file << " vb.customize [\"modifyvm\", :id, \"--memory\", \"#{options['vagrant_memsize'] ||= '1024'}\"]\n" | |||
There was a problem hiding this comment.
where does vagrant_memsize come from? There doesn't seem to be a way to set it in the current code?
There was a problem hiding this comment.
Also, this will leave options['vagrant_memsize'] set to 1024 after this function exits. Is that intended?
There was a problem hiding this comment.
Yes, in case you wish to refer to the memsize later you want to either preserve the setting selected by the user or set it to the default.
|
💚 Test passed. |
| @@ -100,7 +115,7 @@ module Beaker | |||
| before :each do | |||
| FakeFS.activate! | |||
| vagrant.stub( :randmac ).and_return( "0123456789" ) | |||
| vagrant.make_vfile( @hosts ) | |||
| vagrant.make_vfile( @hosts) | |||
- add support for a vagrant_memsize in the config file - default to 1024
|
💚 Test passed. |
(QA-794) make vagrant vm size configurable through beaker
