Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BKR-1423) Pick up Vagrant config for rsync #1634

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

trevor-vaughan
Copy link
Contributor

Ensure that rsync connections use the on-disk Vagrant SSH configuraiton
if an alternate physical SSH configuration has not been specified.

Correlates directly with voxpupuli/beaker-vagrant#28

Ensure that rsync connections use the on-disk Vagrant SSH configuraiton
if an alternate physical SSH configuration has not been specified.

Correlates directly with voxpupuli/beaker-vagrant#28
@highb
Copy link
Contributor

highb commented Mar 18, 2020

I'm looking into the beaker failure now.

@highb
Copy link
Contributor

highb commented Mar 19, 2020

Okay, I have a PR up to fix the issue with Beaker so we can get a good test run on this. Hopefully that will be merged soon.

@trevor-vaughan
Copy link
Contributor Author

@highb Does it make sense, and did you get a chance to look at voxpupuli/beaker-vagrant#28?

@highb
Copy link
Contributor

highb commented Mar 19, 2020

It looks like @sbeaulie is already reviewing the other PR so I'll let him give more feedback there. Given the assumption that self[:vagrant_ssh_config] gets set by beaker-vagrant, this PR makes sense to me. 👍

As an aside, this all seems like a bit of an over-use of hashes where perhaps real objects should have been used instead but that's a path we've already walked down with Beaker so I'm not going to fret about it. 😆

@trevor-vaughan
Copy link
Contributor Author

@highb Heh, couldn't agree more about the Objects but just keeping things going for now.

@sbeaulie
Copy link
Contributor

retest this please

@highb highb merged commit 7ebf11d into voxpupuli:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants