Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop rspec-its dependency in favor of have_attributes #1788

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Mar 18, 2023

No description provided.

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b9ba4ec) 74.37% compared to head (7547860) 74.37%.

❗ Current head 7547860 differs from pull request most recent head b257ab9. Consider uploading reports for the commit b257ab9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1788   +/-   ##
=======================================
  Coverage   74.37%   74.37%           
=======================================
  Files          82       82           
  Lines        4608     4608           
=======================================
  Hits         3427     3427           
  Misses       1181     1181           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jay7x
Copy link
Member

jay7x commented Mar 18, 2023

JFYI, transpec has this to convert from its to RSpec 3 syntax: https://github.com/yujinakayama/transpec/blob/master/lib/transpec/syntax/its.rb

@ekohl
Copy link
Member Author

ekohl commented Mar 18, 2023

I still question if the RSpec/ImplicitSubject cop makes sense.

@ekohl ekohl merged commit f8a07a8 into voxpupuli:master Mar 20, 2023
@ekohl ekohl deleted the drop-rspec-its-dep branch March 20, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants