Only install timesync packages if needed #1853
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1853 +/- ##
===========================================
- Coverage 74.62% 51.60% -23.03%
===========================================
Files 81 81
Lines 4492 4498 +6
===========================================
- Hits 3352 2321 -1031
- Misses 1140 2177 +1037 ☔ View full report in Codecov by Sentry. |
ekohl
force-pushed
the
only-install-timesync-packages-if-needed
branch
from
37a4799
to
423fb62
Compare
bastelfreak
approved these changes
Mar 13, 2024
ekohl
commented
Mar 13, 2024
Chrony/NTP is only needed if timesync is requested. In some cases (like containers) it never makes sense. Which packages are installed is really platform specific logic, so it should live in the platform class.
ekohl
force-pushed
the
only-install-timesync-packages-if-needed
branch
from
6700df9
to
e3ec2d5
Compare
bastelfreak
approved these changes
Mar 14, 2024
|
This is still a draft. The fail because the tests don't ensure platform is an instance of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrony/NTP is only needed if timesync is requested. In some cases (like containers) it never makes sense.
This was inspired by voxpupuli/beaker-hostgenerator#359 (comment) and currently testing it out.