PE-37978: Add 'amazon' to #repo-filename method #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
span786
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1858 +/- ##
=======================================
Coverage 74.53% 74.53%
=======================================
Files 81 81
Lines 4504 4504
=======================================
Hits 3357 3357
Misses 1147 1147 ☔ View full report in Codecov by Sentry. |
span786
force-pushed
the
PE-37978-add-amazon-to-repo-filename-in-voxpupuli-beaker-gem-in-master
branch
from
b8b92d6
to
057a7f2
Compare
|
@span786 can you please rebase so we've a single commit in this PR? |
Revert "[PE-37978]: Add 'amazon' to repo_filename method with tests" This reverts commit 47f1238. [PE-37978]: Add 'amazon' to repo_filename method with tests
span786
force-pushed
the
PE-37978-add-amazon-to-repo-filename-in-voxpupuli-beaker-gem-in-master
branch
from
057a7f2
to
c8e03a2
Compare
|
Hi @bastelfreak, I have squashed the commits into 1. |
TheMeier
reviewed
Mar 22, 2024
| @@ -133,6 +133,14 @@ def to_s | |||
| expect(filename).to be === correct | |||
| end | |||
|
|
|||
| it 'builds the filename correctly for amazon-based platforms' do | |||
| @platform = 'amazon-2023-x86_64' | |||
There was a problem hiding this comment.
No, the 2023 is the release version. Sort of like how Ubuntu has it.
ekohl
approved these changes
Mar 22, 2024
bastelfreak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 'amazon' support in #repo_filename method in lib/beaker/host/unix/file.rb.