(QENG-760) support for additional disk for vagrant #303
Conversation
|
💚 Test passed. |
| v_file << " vb.name = '#{host.name}'\n" | ||
| unless File.exist?(host['disk_path']) | ||
| host['disk_path'] = File.join(host['disk_path'], "#{host.name}.vmdk") | ||
| v_file << " vb.customize ['createhd', '--filename', '#{host['disk_path']}', '--size', #{host['disk_size'] ||= 500 * 1024}, '--format', 'vmdk']\n" |
There was a problem hiding this comment.
According to the documentation, size is in MB. I recommend changing 500 to 5.
VBoxManage createhd --filename <filename>
--size <megabytes>
[--format VDI|VMDK|VHD] (default: VDI)
[--variant Standard,Fixed,Split2G,Stream,ESX]
There was a problem hiding this comment.
I am not sure it matters, but format types are all-caps in the doc vs. lowercase here (vmdk).
|
+1, except I have not run this against vagrant+vb. I have run this PR against the vcloud hypervisor. |
- if a given vagrant box has a disk_path then either create a new vmdk disk or use the provided disk - defaults to 50 x 1024 bytes if the disk needs to created
|
Update to create 5 Gb disk instead of 500. I have tested this with vagrant and seen that it creates and attaches an additional disk. |
|
🔴 Test failed. |
(QENG-760) support for additional disk for vagrant
disk or use the provided disk