Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(gh-305) Start docker containers using privileged mode #311

Merged
merged 1 commit into from
Jun 17, 2014

Conversation

treydock
Copy link
Contributor

No description provided.

@puppetlabs-jenkins
Copy link
Contributor

Can one of the admins verify this patch?

@anodelman
Copy link
Contributor

Please rebase from master to pick up fix for 1.8 spec tests.

@anodelman
Copy link
Contributor

@richardc / @electrical could you look this over with your combined docker expertise?

@electrical
Copy link
Contributor

I had to implement the same change but didn't get around to send a PR yet. ( see electrical@dd9acd4 )
With docker 0.11.0 the privileged option is required, otherwise it messes up certain functionality.

@anodelman
Copy link
Contributor

@electrical is it ignored in earlier versions? I wouldn't want to break any operational setups with this...

@electrical
Copy link
Contributor

Its not ignored in earlier versions but it should not break previous behaviour, it just allows for extra functionality.

@anodelman
Copy link
Contributor

Okay, so I'm just waiting for a rebase here so that this will pass spec. Also, please preface your commits with (MAINT) if they are not associated with a gh issue number or a jira bug number.

@treydock
Copy link
Contributor Author

@anodelman Do I need to put MAINT or is referencing issue #305 sufficient? Will debase tomorrow and update PR.

@anodelman
Copy link
Contributor

You'll want to reference the issue in the commit with (gh-issueno).

@treydock treydock changed the title * Start docker containers using privileged mode, fixes #305 (gh-305) Start docker containers using privileged mode Jun 17, 2014
@treydock
Copy link
Contributor Author

@anodelman Done. Renamed PR too.

anodelman pushed a commit that referenced this pull request Jun 17, 2014
(gh-305) Start docker containers using privileged mode
@anodelman anodelman merged commit 12e74e5 into voxpupuli:master Jun 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants