Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Debian/Ubuntu systems, the proxy is not being set early enough. #483

Closed
wants to merge 1 commit into from
Closed

On Debian/Ubuntu systems, the proxy is not being set early enough. #483

wants to merge 1 commit into from

Conversation

mkrakowitzer
Copy link

As part of validate method, apt-get update runs and packages may need to be
installed. This prevents us from provisioning beaker test vm's on networks that
do not have any internet access other than via a proxy.

As part of validate method, apt-get update runs and packages may need to be
installed. This prevents us from provisioning beaker test vm's on networks that
do not have any internet access other than via a proxy.
@mkrakowitzer
Copy link
Author

I would also like to expand the --package-proxy to possibily set it in .bashrc, /etc/wgetrc and /root/.curlrc, /root/.gemrc. At the moment I cator for this in my spec/spec_helper_acceptance.rb. Let me know if this would be a valuable feature and ill take a stab at it.

@puppetlabs-jenkins
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@puppetlabs-jenkins
Copy link
Contributor

Can one of the admins verify this patch?

@branan
Copy link
Contributor

branan commented Oct 13, 2014

test this please

@branan
Copy link
Contributor

branan commented Oct 13, 2014

Your commit message is not formatted correctly, please see the contributing document

@puppetlabs-jenkins
Copy link
Contributor

🔴 Test failed.
Refer to this link for build results: http://jenkins-beaker.delivery.puppetlabs.net/job/Beaker%20Combined%20Smoketest%20(ec2)/174/

@branan
Copy link
Contributor

branan commented Oct 20, 2014

@mkrakowitzer the test failure was unrelated to your change. Once you fixup your commit message we can merge this.

@colinPL
Copy link
Contributor

colinPL commented Oct 31, 2014

retest this please

@puppetlabs-jenkins
Copy link
Contributor

💚 Test passed.
Refer to this link for build results: http://jenkins-beaker.delivery.puppetlabs.net/job/Beaker%20Combined%20Smoketest%20(ec2)/232/

@anodelman
Copy link
Contributor

Closing in preference for #518 - same effect but changing the logic around a little bit to keep normalcy in beaker steps.

@anodelman anodelman closed this Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants