Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rubocop config from voxpupuli-rubocop #6

Merged
merged 1 commit into from May 5, 2023
Merged

Use rubocop config from voxpupuli-rubocop #6

merged 1 commit into from May 5, 2023

Conversation

bastelfreak
Copy link
Member

@bastelfreak bastelfreak commented Mar 31, 2023 •
edited

Also contains #4

@bastelfreak bastelfreak self-assigned this Mar 31, 2023
@bastelfreak bastelfreak force-pushed the rubocop branch 2 times, most recently from 51a2f26 to 434952d Compare March 31, 2023 12:26
@bastelfreak bastelfreak changed the title rubocop: autofix / rubocop: Use rubocop-rspec & rubocop-rake Use rubocop config from beaker Mar 31, 2023
This was referenced Mar 31, 2023
Closed
Closed
@bastelfreak bastelfreak force-pushed the rubocop branch 2 times, most recently from 1237a3f to 066f7fa Compare March 31, 2023 13:23
ekohl
ekohl requested changes Apr 1, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cops have been fixed and #13 will fix more.

@bastelfreak bastelfreak force-pushed the rubocop branch 6 times, most recently from 54c5ae0 to fa75bde Compare April 2, 2023 14:02
@ekohl
Copy link
Member

ekohl commented Apr 28, 2023

@bastelfreak should we update this to https://github.com/voxpupuli/voxpupuli-rubocop?

@bastelfreak
Copy link
Member Author

yes,will do

ekohl
ekohl reviewed Apr 28, 2023
View reviewed changes
.rubocop_todo.yml Outdated

# Offense count: 9
# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
RSpec/VerifiedDoubles:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#15

ekohl
ekohl reviewed Apr 28, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm kind of leaning to disabling the cops that are in TODO.

.rubocop_todo.yml Outdated Show resolved Hide resolved
.rubocop_todo.yml Outdated Show resolved Hide resolved
Rakefile Outdated Show resolved Hide resolved
@bastelfreak bastelfreak changed the title Use rubocop config from beaker Use rubocop config from voxpupuli-rubocop May 5, 2023
ekohl
ekohl reviewed May 5, 2023
View reviewed changes
.rubocop_todo.yml Outdated Show resolved Hide resolved
beaker_puppet_helpers.gemspec Outdated Show resolved Hide resolved
Rakefile Outdated Show resolved Hide resolved
@bastelfreak bastelfreak force-pushed the rubocop branch 4 times, most recently from 609b346 to 0303aac Compare May 5, 2023 18:49
ekohl
ekohl reviewed May 5, 2023
View reviewed changes
Gemfile Outdated Show resolved Hide resolved
Rakefile Outdated Show resolved Hide resolved
@bastelfreak bastelfreak merged commit b6a0a55 into voxpupuli:master May 5, 2023
6 checks passed
@bastelfreak bastelfreak deleted the rubocop branch May 5, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl requested changes

Assignees

@bastelfreak bastelfreak

Labels
None yet
Projects
Implement Ruby 3.2 support
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bastelfreak @ekohl