Add ENC / reports capability #79
Conversation
| @@ -0,0 +1,470 @@ | |||
| #!/usr/bin/env ruby | |||
There was a problem hiding this comment.
I see a few problems with this:
- the source is GPL-3.0+, we are Apache-2. I don't know if we're allowed to vendor this
- the two files have no indication that they are coming from the foreman project
- How do we keep track of upstream changes? Would it make more sense to pull the files in when we built the container?
There was a problem hiding this comment.
I see
- I have no idea :)
- Would it help with a disclaimer at the top of the files? (don't know if that modification of files breaks any licenses)
- Those two files haven't changed in years, so in practice it probably won't be an issue. But I understand the concern.
There was a problem hiding this comment.
maybe adding a script, that if $SOMETHING is set, it curls in the upstream files from their sources?
There was a problem hiding this comment.
I run this in an air gapped environment, so that wouldn't work for me, unfortunately
There was a problem hiding this comment.
can you please provide the upstrem urls from where the files come from? so that we know how/where to update, look for updates?
There was a problem hiding this comment.
I picked it out from The Foreman's own git repo for their contaiers here.
I can't seem to find other official sources. It is, however, the one that's installed when you install Foreman and Puppet using the installer.
Support setting up ENC and sending reports to external systems. Added supporting files for Foreman (default Foreman files).