Add some CentOS 9 legacy facts #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is obviously not the full run on a vagrant machine, would be better of course but as non vagrant user.... |
|
thanks for the PR, can you please remove this line: https://github.com/voxpupuli/facterdb/blob/master/spec/facts_spec.rb#L93 ? |
traylenator
force-pushed
the
centos9legacy
branch
from
992af99
to
d5d6a7e
Compare
|
Indeed , it missed the commit - thanks. |
This is only manual addition of ``` facter --version 4.2.5 facter operatingsystem operatingsystemmajrelease operatingsystemrelease osfamily hardwaremodel architecture ``` It's certainly enough for rspec-puppet-facts to consider this a valid fact set. In addition it also allows the `redhat` provider for `service` to operate correctly.
traylenator
force-pushed
the
centos9legacy
branch
from
d5d6a7e
to
4fa2d6e
Compare
|
thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only manual addition of
To last CentOS 9 facts.
It's certainly enough for rspec-puppet-facts to consider this a valid
fact set.
In addition it also allows the
redhatprovider forservicetooperate correctly.