Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add popos 21.10 x86_64 facts #236

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Add popos 21.10 x86_64 facts #236

merged 1 commit into from
Feb 17, 2022

Conversation

logicminds
Copy link
Contributor

  • Popos is a derivative of ubuntu

@smortex
Copy link
Member

smortex commented Feb 17, 2022

Also don't forget to bundle exec rake table to update the README 😉

@logicminds
Copy link
Contributor Author

@smortex regarding the failed tests. I did a facter --json. Do I need to run with -p ?

@smortex
Copy link
Member

smortex commented Feb 17, 2022

Better auto-generate everything from Vagrant I think:
https://github.com/voxpupuli/facterdb#add-new-operating-system-support

@bastelfreak
Copy link
Member

I think you need also the --legacy option

@logicminds
Add popos 21.10 x86_64 facts
f7c4751 
  * Popos is a derivative of ubuntu
@logicminds
Copy link
Contributor Author

I'll have to add a vagrant file later. Tests look good now.

@logicminds
Copy link
Contributor Author

With facter 4.2.5 I ran /opt/puppetlabs/bin/facter --show-legacy --json

@logicminds logicminds merged commit cbdbc54 into master Feb 17, 2022
@logicminds logicminds deleted the popos branch February 17, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@logicminds @smortex @bastelfreak