Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opensuse 15 factsets #241

Merged
merged 3 commits into from
Mar 4, 2022
Merged

Conversation

bastelfreak
Copy link
Member

A bit anoying that facter 3->4 seems to have changed the name. I did a test in the puppet-zypprepo repo, which has OpenSUSE in the metadata.json. The name matching isn't case sensitive.

@bastelfreak bastelfreak self-assigned this Mar 3, 2022
@smortex
Copy link
Member

smortex commented Mar 3, 2022

A bit anoying that facter 3->4 seems to have changed the name. I did a test in the puppet-zypprepo repo, which has OpenSUSE in the metadata.json. The name matching isn't case sensitive.

That can probably be considered a bug and fixed in facter? AFAIK only windows is not capitalized and has never been, that's why I never proposed a patch to change it to Windows… but if OpenSUSE become openSUSE, even if string comparison is case insensitive as far as Puppet is concerned, I would consider this a breaking change because things like hiera will break.

Copy link
Member

@dhollinger dhollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to their website, the project is named openSUSE so fire!

@bastelfreak
Copy link
Member Author

I think we can merge this for now to get the factsets. I raised https://tickets.puppetlabs.com/browse/FACT-3108 to address the issue in facter.

@bastelfreak bastelfreak merged commit c032052 into voxpupuli:master Mar 4, 2022
@bastelfreak bastelfreak deleted the opensuse15 branch March 4, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants