You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
do you have preference here? My first feelings are we should switch to PUPPET_GEM_VERSION to avoid the overlap. I think for VP we sometimes set the matchet (>=, ~> as well, but foreman only sets the actual version only?
I didn't want to push my own idea too much, but I'm also leaning to PUPPET_GEM_VERSION. And I'm ok with including the matcher in Foreman. I rarely if ever change it in my local environment and for CI it's trivial to change.
ekohl
changed the title
FInd a convention for specifying Puppet's version to Gemfile
Find a convention for specifying Puppet's version to Gemfile
Jan 13, 2022
Vox Pupuli uses https://github.com/voxpupuli/modulesync_config/blob/a87ca50493f5b1ac09956fd7f8c226cf6fc3165f/moduleroot/Gemfile.erb#L38-L39 or:
The Foreman uses puppetversion = ENV['PUPPET_VERSION'] || '<%= @configs['puppet_version'] %>'
gem 'puppet', puppetversion, :require => false, :groups => [:test] or:
pdk-templates uses https://github.com/puppetlabs/pdk-templates/blob/b851eaa1db21ee695c07da1a9594a86403bfcc18/moduleroot/Gemfile.erb#L103-L109 or (summarized for readability):
So none of these really is the same:
PUPPET_VERSION
as the environment variable but PDK usesPUPPET_GEM_VERSION
~>
If these workflows are to be used by all, it would be good to align on a single convention.
PUPPET_GEM_VERSION
does have the benefit that it doesn't overlap withPUPPET_VERSION
which is also used in beaker-puppet_install_helper (https://github.com/puppetlabs/beaker-puppet_install_helper/blob/41c355b1f83fde562dd5bd6961e2e4eb8b81421c/lib/beaker/puppet_install_helper.rb#L128) which, while archived, is still used by Vox Pupuli and Foreman in their Beaker setups.The text was updated successfully, but these errors were encountered: