Make hashes in arrays indifferent to string/symbol keys #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON::Schema.add_indifferent_access was only able to recurse into hashes directly contained within another hash; as soon as it found a value which was not a hash it stopped. This meant that hashes within arrays were not being made indifferent to the key type, and so data with symbol keys in a hash in an array were failing validation when they should have been valid. This commit adds a minimal test for this case and fixes voxpupuli#104. We think that voxpupuli#104 is a duplicate of voxpupuli#101 and voxpupuli#94 so those issues are likely to be fixed by this as well.
|
Looks good, thanks a ton for adding this! Always never have time to keep up with this library :) |
hoxworth
added a commit
that referenced
this pull request
Jul 16, 2014
Make hashes in arrays indifferent to string/symbol keys
jennyd
added a commit
to alphagov/hmrc-manuals-api
that referenced
this pull request
Jul 17, 2014
This is to pick up our fix to the gem for symbol keys in hashes in
arrays:
voxpupuli/json-schema#105
This means that we can write our test data more idiomatically as ruby
hashes with symbol keys. While working on the schema we had found a
workaround to this which involved calling .to_json on the data before
validating it, but the fix makes this unnecessary.
|
@hoxworth thanks. To help spread the work load how about adopting a policy that anyone that provides a merged PR gets collaborator access? |
|
@apsoto Yeah, I have been meaning to open up the contribution a bit more anyway. I'll get started on this ASAP. |
|
Done and done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON::Schema.add_indifferent_access was only able to recurse into
hashes directly contained within another hash; as soon as it found a
value which was not a hash it stopped. This meant that hashes within
arrays were not being made indifferent to the key type, and so data
with symbol keys in a hash in an array were failing validation when
they should have been valid.
This commit adds a minimal test for this case and fixes #104.
We think that #104 is a duplicate of #101 and #94 so those issues are
likely to be fixed by this as well.