Refactor classes and validator accessor methods #130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few things that have been bugging me in the json-schema codebase, that I thought I could clean up. Here's a summary:
json-schema/validator.rb
defined several classes: errors classes,JSON::Schema::Validator
as well asJSON::Validator
JSON::Validator.validators[]
) was duplicated in a number of places, including the internal url format used byJSON::Validator
to store schemasJSON::Validator
included the methods for getting the version string and metaschema for a validator, making it harder to add new validatorsHopefully this will make the code easier to understand, and make future changes easier.