Extract formats into separate classes #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great to me! |
Merged
RST-J
force-pushed
the
extract_formats
branch
from
d42967e
to
5488f37
Compare
|
👍 |
hoxworth
added a commit
that referenced
this pull request
Oct 26, 2014
Extract formats into separate classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The available (and for V4 adjusted) default formats, among those that were already implemented, are set according to the specs:
http://tools.ietf.org/html/draft-zyp-json-schema-01#section-5.19
http://tools.ietf.org/html/draft-zyp-json-schema-02#section-5.20
http://tools.ietf.org/html/draft-zyp-json-schema-03#section-5.23
http://json-schema.org/latest/json-schema-validation.html#anchor104
If that's Ok I would go on from here and add a mechanism to hook in custom formats.