Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidied the common test suite tests #197

Merged
merged 3 commits into from Nov 30, 2014

Conversation

iainbeeston
Copy link
Contributor

I've put together 3 small tweaks to the common test suite code. In the order that the commits appear:

  1. I've removed an unused variable
  2. I've switched to loading the common test suite json files using the json gem, rather than JSON::Validator.parse, to insulate us from any bugs in our own parsing code
  3. One of the loops was re-redefining the variable test inside a loop (it was previously defined outside the loop - so we were shadowing the original value)

@iainbeeston iainbeeston changed the title Removed unused variable Tidied the common test suite tests Nov 29, 2014
@pd
Copy link
Contributor

pd commented Nov 30, 2014

👍

@RST-J
Copy link
Contributor

RST-J commented Nov 30, 2014

👍

RST-J added a commit that referenced this pull request Nov 30, 2014
Tidied the common test suite tests
@RST-J RST-J merged commit fe39390 into voxpupuli:master Nov 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants