Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add description for nested types array and object #212

Merged
merged 2 commits into from
Dec 16, 2014
Merged

add description for nested types array and object #212

merged 2 commits into from
Dec 16, 2014

Conversation

brancz
Copy link
Contributor

@brancz brancz commented Dec 12, 2014

I realize this is a tiny change, but it took me a while to find how to use the array type. After reading some of Draft 4 and some trial and error I found out how to use it. Unless you read and understand most of Draft 4 it's more or less a trial and error game.

Great job with this project though 👍

@iainbeeston
Copy link
Contributor

I'm confused, isn't this just documenting how json-schema works? (Rather than this particular implementation)

Would it be better to give a link to something like Understanding JSON Schema? (it's far too large a topic to cover in the readme, even if we choose to do so)

@brancz
Copy link
Contributor Author

brancz commented Dec 12, 2014

I agree, it's not specific to this implementation, but a link to the resource you mentioned would definitely be helpful!

@brancz
Copy link
Contributor Author

brancz commented Dec 16, 2014

Should I add the link to the readme and create a new pull request? Or any contributor can add it .. then we can close this.

@iainbeeston
Copy link
Contributor

Sorry, I haven't had a chance myself. If you could replace the explanation with a link I don't see why we wouldn't merge it=

@brancz
Copy link
Contributor Author

brancz commented Dec 16, 2014

There we go 😄

@iainbeeston
Copy link
Contributor

👍 from me.

I'll merge this now (I don't think we need to get the approval of two maintainers for a minor docs change, right?)

iainbeeston added a commit that referenced this pull request Dec 16, 2014
add description for nested types array and object
@iainbeeston iainbeeston merged commit f459d7b into voxpupuli:master Dec 16, 2014
@hoxworth
Copy link
Contributor

no :). but +1 retroactively.

On Dec 16, 2014, at 2:18 AM, Iain Beeston notifications@github.com wrote:

from me.

I'll merge this now (I don't think we need to get the approval of two maintainers for a minor docs change, right?)


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants