Ignore fragments in schema caching. Fixes #233 #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! But can we put the fix in absolutize_ref_uri, after ref_uri is assigned (instead of after absolutize_ref_uri is called) @RST-J Do you think we should roll this into the 2.5.1 release? (It gets my vote) |
|
Yes, let's add this. |
RST-J
added a commit
that referenced
this pull request
Feb 23, 2015
Ignore fragments in schema caching. Fixes #233
|
Cheers guys, glad to have helped! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the URIs used in a
$refare absolute, but include fragments, then the fragment is not removed when the validator searches its cache to see what schemas are loaded, leading to duplication of schemas in the cache.This code & test fixes that issue.