Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call URI.open directly #459

Closed
wants to merge 1 commit into from
Closed

Call URI.open directly #459

wants to merge 1 commit into from

Conversation

laurentqro
Copy link

Removes warning: "calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open"

Removes warning: "calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open"
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this breaks Ruby 2.4 support. Perhaps we should modify this to 2.5+

s.required_ruby_version = ">= 1.9"

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #459 (d895570) into master (450489b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #459   +/-   ##
=======================================
  Coverage   89.75%   89.75%           
=======================================
  Files          74       74           
  Lines        1581     1581           
=======================================
  Hits         1419     1419           
  Misses        162      162           
Impacted Files Coverage Δ
lib/json-schema/schema/reader.rb 98.07% <100.00%> (ø)
lib/json-schema/validator.rb 84.59% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 450489b...d895570. Read the comment docs.

@bastelfreak
Copy link
Member

thanks for the PR, merged it in #462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants