Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing require 'stringio' #512

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

jmarrec
Copy link
Contributor

@jmarrec jmarrec commented May 22, 2024

In some cases, such a statically built ruby 3.x, I definitely get NameError: uninitialized constant IO::StringIO

In some cases, such a statically built ruby 3.x, I definitely get `NameError: uninitialized constant IO::StringIO`
@bastelfreak
Copy link
Member

I think that's a bug in the ruby version you're using, but I think it won't hurt us to explicitly require it. I had similar issues with json in other projects.

@bastelfreak bastelfreak merged commit 54f4807 into voxpupuli:master May 22, 2024
12 checks passed
@jmarrec
Copy link
Contributor Author

jmarrec commented May 23, 2024

@bastelfreak What I meant by "statically built ruby" iss that I use a ruby built with --enable-static and --with-static-linked-ext which is indeed unusual.
Thanks for the merge!

@jmarrec jmarrec deleted the patch-1 branch May 23, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants