renamed provider to fit current status of alternative usage in distributions / Add SLES12/15 support #101

pseiler · 2019-12-13T12:42:38Z

Pull Request (PR) description

I renamed the rpm provider for this module as it fits the current distribution usage more. I also tested support for SLES12 and SLES15, which have the same functionality in update-alternatives as debian-based systems have. RHEL based system instead chkconfigs implementation.

Things I've done:

renamed 'rpm' to 'chkconfig'
added 'osfamily' 'Suse' as default for 'dpkg' provider
(tested with SLES12 SP4 and SLES15 SP1)
updated metadata.json according to new SLES support

pseiler · 2019-12-13T16:14:00Z

I'll fix the failing travis checks ;)

pseiler · 2019-12-13T16:24:04Z

@ekohl maybou you'll have a look. Thank you in advance!

ekohl · 2019-12-13T16:41:18Z

I don't really use alternatives so I feel like I'm not very qualified to review.

bastelfreak

This looks good to me, but I will leave this open so someone with more knowledge about types/providers and/or alternatives can have a look as well.

vox-pupuli-tasks · 2019-12-22T00:02:42Z

Dear @pseiler, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks · 2019-12-22T00:02:42Z

Dear @pseiler, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

pseiler · 2019-12-29T15:34:25Z

any news regarding this pr?

ghoneycutt

I do not get the motivation to rename things from their technology (rpm, dpkg) to an interpretation of how old they are (current, legacy). This is not the norm with any other set of providers.

Believe that Suse support can be added to existing providers using constraints.

pseiler · 2019-12-30T22:57:47Z

@ghoneycutt what would be a good solution? I have no idea.

As SUSE based systems use rpm, not dpkg imo the provider name is wrong as SUSE belongs to dpkg based system in this constellation

pseiler · 2020-01-17T13:49:20Z

ping

pseiler · 2020-01-27T14:00:35Z

ping

pseiler · 2020-02-19T09:32:46Z

Can this be merged or could someone provide me a hint to another solution for this. I'd like to use this code in our productive environment which contain SLES servers.

Without a change like this the puppet run on our SLES servers would fail. And maintaining a fork is also a bad idea.
@ghoneycutt @bastelfreak @ekohl

pseiler · 2020-04-01T08:15:01Z

ping

ekohl · 2020-04-02T15:49:49Z

I disagree with the naming. RPM based uses https://github.com/fedora-sysv/chkconfig which isn't an old version but really a different flavor. Fedora uses that and it's still receiving updates. In Debian it's provided by dpkg as a util. I don't know what the upstream for Suse is but following the naming of upstreams is probably more correct.

pseiler · 2020-04-03T10:30:21Z

I also researched again and got the same result. I also checked SUSE distributions and they indeed use the debian tools.
Proof:

rpm -qpi https://download.opensuse.org/distribution/leap/15.1/repo/oss/x86_64/update-alternatives-1.19.0.4-lp151.3.67.x86_64.rpm

Output on a SLES machine:

Name        : update-alternatives
Version     : 1.18.4
Release     : 16.3.1
Architecture: x86_64
[...]
URL         : http://ftp.de.debian.org/debian/pool/main/d/dpkg/
Summary     : Maintain symbolic links determining default commands
Description :
[...]

I now suggest following naming scheme
dpkg (leave as it is because something like (dpkg-utils) includes a hyphen which introduces unwanted file names)
rpm -> chkconfig

Is this okay with you @ekohl. If yes I will update this pr and mention you again?

vox-pupuli-tasks · 2020-04-06T08:24:49Z

Dear @pseiler, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks · 2020-04-06T08:24:49Z

Dear @pseiler, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks · 2020-04-06T08:24:49Z

Dear @pseiler, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

* SLES and openSUSE use alternatives from debians dpkg project

pseiler · 2020-04-08T09:08:45Z

@ekohl @ghoneycutt I just changed everything so it fit's our discussion etc. I also updated the introduction message so it won't get confusing. Please have a look and merge it, if everything is fine.

pseiler · 2020-04-14T11:31:14Z

The travis check was successfull. Mabye some hiccup

ekohl

I think this naming makes sense.

Travis has had some reliability issues recently with reporting back so that's probably it, but manually clicking through shows it did indeed pass.

@ghoneycutt I'll leave this for you since you previously had comments.

bastelfreak approved these changes Dec 15, 2019

View reviewed changes

bastelfreak changed the title ~~renamed providers to fit current status of alternative usage in distributions~~ renamed providers to fit current status of alternative usage in distributions / Add SLES12/15 support Dec 15, 2019

bastelfreak added the enhancement New feature or request label Dec 15, 2019

vox-pupuli-tasks bot added the merge-conflicts label Dec 22, 2019

vox-pupuli-tasks bot removed the merge-conflicts label Dec 22, 2019

ghoneycutt self-requested a review December 30, 2019 16:09

ghoneycutt requested changes Dec 30, 2019

View reviewed changes

pseiler requested a review from ghoneycutt March 1, 2020 15:49

vox-pupuli-tasks bot added merge-conflicts labels Apr 6, 2020

pseiler added 2 commits April 8, 2020 10:33

renamed provider from rpm to chkconfig as this fits fetter

6bdb363

added support for SLES systems

c47ae6a

* SLES and openSUSE use alternatives from debians dpkg project

vox-pupuli-tasks bot removed merge-conflicts merge-conflicts labels Apr 8, 2020

pseiler changed the title ~~renamed providers to fit current status of alternative usage in distributions / Add SLES12/15 support~~ renamed provider to fit current status of alternative usage in distributions / Add SLES12/15 support Apr 8, 2020

pseiler mentioned this pull request Apr 8, 2020

SLES 12 and 15 do not work with puppet-alternatives #105

Closed

ekohl approved these changes Apr 14, 2020

View reviewed changes

bastelfreak merged commit 8ba502f into voxpupuli:master Apr 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

renamed provider to fit current status of alternative usage in distributions / Add SLES12/15 support #101

renamed provider to fit current status of alternative usage in distributions / Add SLES12/15 support #101

pseiler commented Dec 13, 2019 •

edited

Loading

pseiler commented Dec 13, 2019

pseiler commented Dec 13, 2019

ekohl commented Dec 13, 2019

bastelfreak left a comment

vox-pupuli-tasks bot commented Dec 22, 2019

vox-pupuli-tasks bot commented Dec 22, 2019

pseiler commented Dec 29, 2019

ghoneycutt left a comment

pseiler commented Dec 30, 2019

pseiler commented Jan 17, 2020

pseiler commented Jan 27, 2020

pseiler commented Feb 19, 2020

pseiler commented Apr 1, 2020

ekohl commented Apr 2, 2020

pseiler commented Apr 3, 2020 •

edited

Loading

vox-pupuli-tasks bot commented Apr 6, 2020

vox-pupuli-tasks bot commented Apr 6, 2020

vox-pupuli-tasks bot commented Apr 6, 2020

pseiler commented Apr 8, 2020

pseiler commented Apr 14, 2020

ekohl left a comment

renamed provider to fit current status of alternative usage in distributions / Add SLES12/15 support #101

renamed provider to fit current status of alternative usage in distributions / Add SLES12/15 support #101

Conversation

pseiler commented Dec 13, 2019 • edited Loading

Pull Request (PR) description

pseiler commented Dec 13, 2019

pseiler commented Dec 13, 2019

ekohl commented Dec 13, 2019

bastelfreak left a comment

Choose a reason for hiding this comment

vox-pupuli-tasks bot commented Dec 22, 2019

vox-pupuli-tasks bot commented Dec 22, 2019

pseiler commented Dec 29, 2019

ghoneycutt left a comment

Choose a reason for hiding this comment

pseiler commented Dec 30, 2019

pseiler commented Jan 17, 2020

pseiler commented Jan 27, 2020

pseiler commented Feb 19, 2020

pseiler commented Apr 1, 2020

ekohl commented Apr 2, 2020

pseiler commented Apr 3, 2020 • edited Loading

vox-pupuli-tasks bot commented Apr 6, 2020

vox-pupuli-tasks bot commented Apr 6, 2020

vox-pupuli-tasks bot commented Apr 6, 2020

pseiler commented Apr 8, 2020

pseiler commented Apr 14, 2020

ekohl left a comment

Choose a reason for hiding this comment

pseiler commented Dec 13, 2019 •

edited

Loading

pseiler commented Apr 3, 2020 •

edited

Loading