Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not overwrite destination while downloading #23

Closed
apeeters opened this issue Jan 12, 2015 · 1 comment · Fixed by #26
Closed

Do not overwrite destination while downloading #23

apeeters opened this issue Jan 12, 2015 · 1 comment · Fixed by #26
Labels
enhancement New feature or request

Comments

@apeeters
Copy link

Currently the destination file becomes size 0 bytes while the download is in progress. Please consider using a temp file for downloading and only overwrite the destination when the download was successful and checksum matches.

This would suit our scenario where we download a war and overwrite a previous version in the webapps directory.
@nanliu nanliu added the enhancement New feature or request label Jan 15, 2015
nanliu added a commit that referenced this issue Feb 9, 2015
@nanliu
Download files to temporary directory first.
d5e466b 
Fix #23
@nanliu nanliu mentioned this issue Feb 9, 2015
Merged
nanliu added a commit that referenced this issue Feb 9, 2015
@nanliu
Download files to temporary directory first.
a77fbd9 
Fix #23
nanliu added a commit that referenced this issue Feb 9, 2015
@nanliu
Download files to temporary directory first.
552c0e0 
Fix #23
@nanliu nanliu closed this as completed in #26 Feb 9, 2015
@apeeters
Copy link
Author

Thanks!

cegeka-jenkins pushed a commit to cegeka/puppet-archive that referenced this issue Oct 23, 2017
@nanliu
Download files to temporary directory first.
a7378d2 
Fix voxpupuli#23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Download files to temporary directory first. voxpupuli/puppet-archive
2 participants
@apeeters @nanliu