Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query string breaks file:// behavior #56

Closed
jairojunior opened this issue May 12, 2015 · 3 comments
Closed

Query string breaks file:// behavior #56

jairojunior opened this issue May 12, 2015 · 3 comments

Comments

@jairojunior
Copy link

Query string is currently hardcoded in url_path, but it breaks file:// behavior cause '?' (question mark) is a valid character for file names.

I managed to work in a simple fix, but I think each implementation (HTTP, FTP, File) should receive an URI and handle its own internal behavior (include or not a query string). What do you think?

We'll also need tests for this...
@jairojunior jairojunior mentioned this issue May 13, 2015
Merged
jairojunior added a commit to jairojunior/puppet-archive that referenced this issue May 13, 2015
@jairojunior
Fix issue voxpupuli#56
3bcb3e3
@jairojunior
Copy link
Author

@nanliu Can you verify PR #57?

@nanliu
Copy link
Contributor

nanliu commented May 20, 2015

I'll review it today.

nanliu added a commit that referenced this issue May 21, 2015
@nanliu
Merge pull request #57 from jairojunior/master
80c57e5 
Fix issue #56
@nanliu
Copy link
Contributor

nanliu commented May 21, 2015

Close #57

@nanliu nanliu closed this as completed May 21, 2015
cegeka-jenkins pushed a commit to cegeka/puppet-archive that referenced this issue Oct 23, 2017
@jairojunior
Fix issue voxpupuli#56
c7a5066
cegeka-jenkins pushed a commit to cegeka/puppet-archive that referenced this issue Oct 23, 2017
@nanliu
Merge pull request voxpupuli#57 from jairojunior/master
4713d1d 
Fix issue voxpupuli#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nanliu @jairojunior