Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid creating file autorequire with nil variable #167

Merged
merged 1 commit into from May 20, 2016

Conversation

hdeadman
Copy link
Contributor

This is a fix for #166.

].each do |file|
autos << file unless file.nil?
end
autos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just do .compact on the array. Also we might consider only adding /root/.aws on posix platforms.

@nanliu
Copy link
Contributor

nanliu commented May 19, 2016

Would appreciate a spec test supporting this change.

@hdeadman
Copy link
Contributor Author

I updated to use compact. I don't have much Ruby experience but I figured there was a simple way to do it. I am not currently setup to run spec tests, I have only ever written one, but would adding Puppet 4.5 to the travis text matrix cause many of the existing tests to fail (since they don't set the extract_path argument)? The error happens during catalog execution (vs compilation), do tests involve executing the catalog?

@rnelson0
Copy link
Sponsor Member

Unit tests (rspec-puppet) are catalog only, testing the state immediately
after compilation. Acceptance tests (beaker) can be used to test the
results of execution.

Rob Nelson
rnelson0@gmail.com

@jyaworski
Copy link
Member

Hi @hdeadman. As @rnelson0 mentioned our acceptance testing is a bit sub-par right now. We're actively looking into how to improve this.

That being said, I can accept this PR without a spec test due to its nature. Can you squash your commits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants