Bug: When managing both Port and ListenAddress in sshd_config, Port *must* precede ListenAddress

[trevor-vaughan]

Currently, the module simply appends Port to the end of the list which causes sshd to fail to restart.

[raphink]

Thank you for the report. This might not be very easy to fix, as it will require to implement positioning and add some parameter intelligence to the provider.

[raphink]

Do you know of other parameters for which order matters in sshd_config?

[trevor-vaughan]

As far as I can tell, that's the only set that matters.

On Fri, Feb 21, 2014 at 2:43 AM, Raphaël Pinson notifications@github.comwrote:

Do you know of other parameters for which order matters in sshd_config?

Reply to this email directly or view it on GitHubhttps://github.com//issues/68#issuecomment-35705661
.

Trevor Vaughan
Vice President, Onyx Point, Inc
(410) 541-6699
tvaughan@onyxpoint.com

-- This account not approved for unencrypted proprietary information --

[raphink]

OK. I can try to see what I can do.

[raphink]

I had a hard time reproducing the bug with the unit tests, because this already works if you have a commented Port entry before the first ListenAddress entry. Indeed, the current code uncomments existing commented entries, so if you have:

# Port 22
ListenAddress ::

and you set:

sshd_config { 'Port':
  value => '2222',
}

it will uncomment the value, and the order will be fine.

[trevor-vaughan]

Fair enough, but if you try it in a Host sub-entry, it won't work.

On Fri, Feb 21, 2014 at 10:28 AM, Raphaël Pinson
notifications@github.comwrote:

I had a hard time reproducing the bug with the unit tests, because this
already works if you have a commented Port entry before the first
ListenAddress entry. Indeed, the current code uncomments existing commented
entries, so if you have:

Port 22

Listenaddress ::

and you set:

sshd_config { 'Port':
value => '2222',
}

it will uncomment the value, and the order will be fine.

Reply to this email directly or view it on GitHubhttps://github.com//issues/68#issuecomment-35740176
.

Trevor Vaughan
Vice President, Onyx Point, Inc
(410) 541-6699
tvaughan@onyxpoint.com

-- This account not approved for unencrypted proprietary information --

[raphink]

I did commit a patch for the create method as 82d702b

[raphink]

Having a look at doing that inside Match blocks now.

[trevor-vaughan]

+1

Thanks!

Trevor

On Fri, Feb 21, 2014 at 10:32 AM, Raphaël Pinson
notifications@github.comwrote:

Having a look at doing that inside Match blocks now.

Reply to this email directly or view it on GitHubhttps://github.com//issues/68#issuecomment-35740645
.

Trevor Vaughan
Vice President, Onyx Point, Inc
(410) 541-6699
tvaughan@onyxpoint.com

-- This account not approved for unencrypted proprietary information --

[raphink]

Fixed in abb8adc