Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grub_menuentry is broken in EL8 and Fedora 30+ #49

Closed
trevor-vaughan opened this issue Mar 2, 2020 · 4 comments · Fixed by #50
Closed

grub_menuentry is broken in EL8 and Fedora 30+ #49

trevor-vaughan opened this issue Mar 2, 2020 · 4 comments · Fixed by #50
Labels
bug Something isn't working

Comments

@trevor-vaughan
Copy link
Contributor

EL8 and Fedora 30+ now use the blscfg module to load OS configurations from /boot/loader/entries. This means that we're going to have to fall back to grubby for systems that include this module in their /etc/grub2.cfg configuration until some method can be found to process this information without requiring grubby.
@raphink raphink added the bug Something isn't working label Mar 5, 2020
@jcpunk
Copy link

jcpunk commented Mar 10, 2020

Perhaps parsing grubenv would help?

https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/managing_monitoring_and_updating_the_kernel/configuring-kernel-command-line-parameters_managing-monitoring-and-updating-the-kernel#what-are-boot-entries_configuring-kernel-command-line-parameters

@trevor-vaughan
Copy link
Contributor Author

@jcpunk I'm actually working on that now. Luckily, the new rewrite of grubby is in BASH so I've been able to reverse engineer things.

Unfortunately, it's kind of a hot mess under the hood and we're going to have to support both BLS and old entries to make this thing make any kind of sense.

Also, updating the root disk seems to update it for all BLS entries (it just keeps getting more fun).

trevor-vaughan added a commit to trevor-vaughan/augeasproviders_grub that referenced this issue Mar 18, 2020
@trevor-vaughan
Add BLS support to grub_menuentry
ec748c7 
* Adds BLS support which should fix issues on EL8 and Fedora 30
* Fixed the issue with duplicating kernel options while debugging
* Updates both non-EFI and EFI paths

Closes voxpupuli#49
Closes voxpupuli#38
Closes voxpupuli#37
@trevor-vaughan trevor-vaughan mentioned this issue Mar 18, 2020
Merged
@trevor-vaughan
Copy link
Contributor Author

@jcpunk PR is up if you want to take a look

@jcpunk
Copy link

jcpunk commented Mar 19, 2020

Excellent :)

raphink pushed a commit that referenced this issue Mar 23, 2020
@trevor-vaughan
Add BLS support to grub_menuentry (#50)
15e7352 
* Add BLS support to grub_menuentry

* Adds BLS support which should fix issues on EL8 and Fedora 30
* Fixed the issue with duplicating kernel options while debugging
* Updates both non-EFI and EFI paths

Closes #49
Closes #38
Closes #37

* Work around provider boolean issue

Also fixed a couple of minor issues with pre-populating provider data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add BLS support to grub_menuentry trevor-vaughan/augeasproviders_grub
3 participants
@raphink @jcpunk @trevor-vaughan