Added support for global GRUB configuration #18
Conversation
This patch adds support for grub_menuentry which provides the ability to manage individual Menu entries for both GRUB Legacy and GRUB2. Testing has been focused on Linux-based operating systems and it is possible that features may be missing for chainloaded operating systems. Support for managing GRUB2 users has also been added. This compares against the *running* configuration, not what is saved in the compilation files in grub.d. The following custom types were created: * grub_config => Manages global GRUB settings * grub_menuentry => Manages GRUB menuentries * grub_user => Manages GRUB2 users Fixes voxpupuli#10
trevor-vaughan
force-pushed
the
ISSUE-10
branch
from
0735fa3
to
86fca6f
Compare
|
That is quite a PR! Would you mind splitting the providers in separate PRs please? Also, if you provide the format, I don't mind providing the missing lenses. |
|
Hi @raphink. I don't mind, but I don't know that I'll have time for a while as we're trying to push out a new build and free time is at an all time low. Would you prefer one PR per provider? My GRUB2 menuentry parser starts at https://github.com/trevor-vaughan/augeasproviders_grub/blob/86fca6f5b9dbdf16a3f714270b36137fd8b4bb58/lib/puppet/provider/grub_menuentry/grub2.rb#L22 |
|
@trevor-vaughan Actually, since it's not your first large contribution, how about I give you commit rights on augeasproviders projects and you can add this yourself to the project? |
|
@raphink That would be awesome but...are you sure? I'll make sure to have issue discussions before doing anything drastic. Thanks! |
|
I trust you. And I'll try to have a look anyway before merging, in case I have suggestions. |
|
Closed by mistake (wrong button) |
Added support for global GRUB configuration
|
OK. Could you update the change log and tag 2.4.0 please? |
|
Sorry about this. I just realized that I bumped to 2.3.1. We didn't add any breaking changes, just new features. Should this be 2.4.0 or 2.3.1? |
|
New features means new minor, hence 2.4.0. Breaking changes would mean new major (3.0.0). Version 2.3.1 would mean bugfix. For easy reference: https://twitter.com/auroraeosrose/status/585209388857700352 |
This patch adds support for grub_menuentry which provides the ability to
manage individual Menu entries for both GRUB Legacy and GRUB2.
Testing has been focused on Linux-based operating systems and it is
possible that features may be missing for chainloaded operating systems.
Support for managing GRUB2 users has also been added. This compares
against the running configuration, not what is saved in the
compilation files in grub.d.
The following custom types were created:
Fixes #10