-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grub2 grub_user fix #32
Grub2 grub_user fix #32
Conversation
The user generation script was incorrectly outputting additional erronous information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you call the puppetx::augeasprovidersGrub::grub2_cfg to find the grub.cfg file it takes the first one it finds. Suggest you add a check for /sys/firmware/efi and if efi, get only the efi files and visa versa. Someone might go in and erroneaulsy edit or create a /boot/grub2 config file and they will be hosed. Also why include /boot/grub/grub.cfg since that is only grub not grub2?
Also, name the file in grub.d something so it will get included after 01_users because the superuser setting from 01_users will win if it is later in the grub file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed these and tested them out on a system and they work.
Since that's what Ubuntu uses for Grub2 configuration. Grub1 would use See #36 for my fixup PR. |
The user generation script was incorrectly outputting additional
erronous information