Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide the option to only update the live value #15

Merged
merged 6 commits into from
May 31, 2017
Merged

Provide the option to only update the live value #15

merged 6 commits into from
May 31, 2017

Conversation

trevor-vaughan
Copy link
Contributor

There are some sysctl values which, when set in /etc/sysctl.conf, may
cause operational harm to a system.

This patch provides the ability to only update the live value and make
the disk persistence optional.

Additionally:

  • Now use prefetching to get the sysctl values
  • Updated self.instances to obtain information about all sysctl values
    which provides a more accurate representation of the system when using
    puppet resource
  • Fail if the user attempts to set a value that is not valid on the
    system unless silent is set.
  • Updated all tests

Closes #14

@trevor-vaughan
Provide the option to only update the live value
5729f13 
There are some sysctl values which, when set in /etc/sysctl.conf, may
cause operational harm to a system.

This patch provides the ability to only update the live value and make
the disk persistence optional.

Additionally:
- Now use prefetching to get the sysctl values
- Updated self.instances to obtain information about all sysctl values
  which provides a more accurate representation of the system when using
  `puppet resource`
- Fail if the user attempts to set a value that is not valid on the
  system unless `silent` is set.
- Updated all tests

Closes voxpupuli#14
@trevor-vaughan trevor-vaughan self-assigned this May 12, 2017
@coveralls
Copy link

coveralls commented May 12, 2017 •
edited

Coverage Status

Coverage decreased (-3.2%) to 89.535% when pulling 5729f13 on trevor-vaughan:optional_disk_persistence into 1795545 on hercules-team:master.

@coveralls
Copy link

coveralls commented May 12, 2017 •
edited

Coverage Status

Coverage decreased (-4.4%) to 88.304% when pulling 6c69100 on trevor-vaughan:optional_disk_persistence into 1795545 on hercules-team:master.

@trevor-vaughan
Add OpenSUSE support
ec7e152 
Nodesets are complete
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.4%) to 88.304% when pulling ec7e152 on trevor-vaughan:optional_disk_persistence into 1795545 on hercules-team:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.4%) to 88.304% when pulling ec7e152 on trevor-vaughan:optional_disk_persistence into 1795545 on hercules-team:master.

@coveralls
Copy link

coveralls commented May 22, 2017 •
edited

Coverage Status

Coverage decreased (-4.4%) to 88.304% when pulling f343b62 on trevor-vaughan:optional_disk_persistence into 1795545 on hercules-team:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.4%) to 88.304% when pulling f343b62 on trevor-vaughan:optional_disk_persistence into 1795545 on hercules-team:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.4%) to 88.304% when pulling f343b62 on trevor-vaughan:optional_disk_persistence into 1795545 on hercules-team:master.

nick-markowski
nick-markowski approved these changes May 31, 2017
View reviewed changes
Copy link
Contributor

@nick-markowski nick-markowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcomed functionality updates and good tests

@trevor-vaughan trevor-vaughan merged commit 012cd99 into voxpupuli:master May 31, 2017
@alexjfisher alexjfisher mentioned this pull request Oct 21, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-markowski nick-markowski nick-markowski approved these changes

@raphink raphink Awaiting requested review from raphink

Assignees

@trevor-vaughan trevor-vaughan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trevor-vaughan @coveralls @nick-markowski