Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add support for Darwin #127

Closed
helge000 opened this issue Jun 7, 2018 · 5 comments
Closed

Feature: Add support for Darwin #127

helge000 opened this issue Jun 7, 2018 · 5 comments

Comments

@helge000
Copy link

helge000 commented Jun 7, 2018

Support for Darwin is quite simple to add IMHO.
helge000 added a commit to helge000/puppet-autofs that referenced this issue Jun 7, 2018
@helge000
Closes voxpupuli#127
68a9c6c 
I tested this simple extention against MacOS 10.10,10.11,10.12. The
same thing also works on MacOS 10.9, so I added it also.

On Darwin, we need to handle two services: I changed `$service_name` to
a variant to accept arrays.
helge000 added a commit to helge000/puppet-autofs that referenced this issue Jun 8, 2018
@helge000
Closes voxpupuli#127
c69a0c9 
I tested this simple extention against MacOS 10.10,10.11,10.12. The
same thing also works on MacOS 10.9, so I added it also.

On Darwin, we need to handle two services: I changed `$service_name` to
a variant to accept arrays.
helge000 added a commit to helge000/puppet-autofs that referenced this issue Jun 15, 2018
@helge000
Closes voxpupuli#127
532b33c 
I tested this simple extention against MacOS 10.10,10.11,10.12. The
same thing also works on MacOS 10.9, so I added it also.

On Darwin, we need to handle two services: I changed `$service_name` to
a variant to accept arrays.
helge000 added a commit to helge000/puppet-autofs that referenced this issue Jun 15, 2018
@helge000
Closes voxpupuli#127
e45924a 
I tested this simple extention against MacOS 10.10,10.11,10.12. The
same thing also works on MacOS 10.9, so I added it also.

On Darwin, we need to handle two services: I changed `$service_name` to
a variant to accept arrays.
helge000 added a commit to helge000/puppet-autofs that referenced this issue Jun 15, 2018
@helge000
Closes voxpupuli#127
d87d723 
I tested this simple extention against MacOS 10.10,10.11,10.12. The
same thing also works on MacOS 10.9, so I added it also.

On Darwin, we need to handle two services: I changed `$service_name` to
a variant to accept arrays.
@dhollinger
Copy link
Member

We can merge #128, but it is important to note that we as a community are not equipped to officially support Darwin/MacOS from a troubleshooting standpoint

helge000 added a commit to helge000/puppet-autofs that referenced this issue Jun 28, 2018
@helge000
Closes voxpupuli#127
f05e8c5 
I tested this simple extention against MacOS 10.10,10.11,10.12. The
same thing also works on MacOS 10.9, so I added it also.

On Darwin, we need to handle two services: I changed `$service_name` to
a variant to accept arrays.
@helge000
Copy link
Author

I just moved the line Mac OS X in README.md. There, it already states:

Self Support - should work, support not provided by developer

I think this covers your concern, @dhollinger ?

@dhollinger
Copy link
Member

closing as stale

@helge000
Copy link
Author

@dhollinger, can you offer at least some reason for closing this PR?
I was waiting for a reply from you for eight months now, after all.

@Dan33l
Copy link
Member

Dan33l commented Feb 12, 2019

It was asked to remove MacOSX from the supported OSes in the PR. And it looks it was not done.
As already said by @dhollinger :

  • we can not run tests MasOSX in the CI
  • as a community are not equipped to officially support Darwin/MacOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dhollinger @Dan33l @helge000