Made the Autofs::Mapentry type more permissive #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Autofs::Mapentry type rejected some map designations that Autofs itself permits. The type is updated to accept all valid designations that aren't plain absolute paths. Inasmuch as the accepted designations vary with the specified map type, and this data type (still) does not make distinctions based on map type, it now accepts some map designations that Autofs will reject. Specifically, for 'file', 'directory', and 'program' map types, Autofs expects the map name to be an absolute path, and the Autofs::Mapentry data type no longer enforces this.
Applied some code-style adjustments to satisfy the RuboCop-enforced style rules for the project.
juniorsysadmin
approved these changes
Mar 29, 2018
dhollinger
approved these changes
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The Autofs::Mapentry type rejected some map designations that Autofs itself
permits. The type is updated to accept all valid designations that
aren't plain absolute paths.
Inasmuch as the accepted designations vary with the specified map type,
and this data type does not make distinctions based on map type (and never
did), it now accepts some map designations that Autofs will reject.
Specifically, for 'file', 'directory', and 'program' map types, Autofs expects
the map name to be an absolute path, and the Autofs::Mapentry data
type no longer enforces this. This is a direct consequence of the type
now intentionally allowing map names for other map types that do
not have the form of absolute paths.
This Pull Request (PR) fixes the following issues
Fixes #115