Enable LDAP in autofs

[coreone]

Pull Request (PR) description

Enable LDAP as an option when using autofs. This requires being able to modify the following files:

• /etc/sysconfig/autofs (or /etc/default/autofs on Debian systems)
• /etc/autofs_ldap_auth.conf

By default, neither of these files is managed by this module to prevent backward compatibility with existing configurations. Management of the files can be turned on individually via the autofs::manage_service_config
and autofs::manage_ldap_auth_conf booleans. Basic spec tests were also added.

[dhollinger]

@coreone Looks like there are some failing tests, can you look into those?

[coreone]

I can look into the failing tests, but they are unrelated to the changes in this PR.

[coreone]

@dhollinger I fixed the linting errors I found, but I can't figure out why the tests are failing. I think it's somehow Travis-related. When I run the test and test_with_coveralls rake tasks on my local environment, all the tests pass.

[coreone]

@dhollinger Researched this a little. I think the problem here is that facter 2.5 dropped support for OpenSUSE 13.x from the matrix here:

https://github.com/camptocamp/facterdb

So, the only path forward here is probably:

• Remove OpenSUSE from metadata.json
• Move OpenSUSE support in metadata.json to 42
• Set FACTER_GEM_VERSION to stay at < 2.5

For a test, I'm going to set OpenSUSE to 42 to see if that indeed clears up the tests.

[coreone]

Tests now pass. The changes were:

• Update OpenSUSE version to 42 to get around deprecated 13.1 version that is no longer supported by updated versions of facter
• Update the autofs_version fact to use Facter::Util::Resolution instead of Facter::Core::Execution to fix the Travis checks.

[coreone]

@bastelfreak converted erb templates to epp

[coreone]

@dhollinger is anything further needed on this?

[ekohl]

My apologies, I didn't see this PR. I just merged #166 where I changed it to 15 so at least the tests passed. Please rebase this on current master.

I should also admit that I didn't test it on OpenSUSE.

[coreone]

@ekohl This has been rebased. I removed the OpenSuSE version change since 15.2 in your PR fixed the issue.

[ekohl]

Thanks! I can't comment too much on the content since I don't use autofs myself. The code itself looks good.

Since @dhollinger did at least a partial review I'll leave it up to him to take a last look. If he has no time, feel free to ping and then I think it can just be merged.

[kenyon]

What about some update to README.md about the new features? Also Puppet Strings documentation so that new parameters get added to REFERENCE.md when it's regenerated.

[coreone]

@kenyon added a section to the README about the LDAP changes as well as Puppet Strings inline docs. Also cleaned up most of the linting errors in the README while I was in there.

[dhollinger]

LGTM