Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to add +auto.master in auto.master file #183

Merged
merged 5 commits into from
Aug 22, 2022
Merged

Allow to add +auto.master in auto.master file #183

merged 5 commits into from
Aug 22, 2022

Conversation

erobhal
Copy link
Contributor

@erobhal erobhal commented Jul 28, 2022

Pull Request (PR) description

Allows inclusion of +auto.master in /etc/auto.master by adding this to the 'mapfiles' property:

"/etc/auto.master":
    mappings:
    - key: "+"
      fs: "auto.master"

This Pull Request (PR) fixes the following issues

manifests/mapping.pp Outdated Show resolved Hide resolved
erobhal and others added 2 commits August 5, 2022 09:44
Co-authored-by: Kenyon Ralph <kenyon@kenyonralph.com>
@kenyon
Copy link
Member

kenyon commented Aug 5, 2022

It looks like the only reason you can't do this with the current implementation is that you can't have whitespace between the + and the map name. Is that right?

@erobhal
Copy link
Contributor Author

erobhal commented Aug 8, 2022

That is correct

@bastelfreak bastelfreak added the enhancement New feature or request label Aug 22, 2022
@bastelfreak
Copy link
Member

@erobhal thanks for the PR. can you maybe add a unit test for the change to verify the created file? Do you think this is a breaking change?

@erobhal
Copy link
Contributor Author

erobhal commented Aug 22, 2022

@bastelfreak Been a while since I coded puppet modules and I have never used puppet acceptance tests, so not sure how to do that. The change should not affect mappings not using a plus sign as key so I can't see that it would break anything.

@erobhal
Copy link
Contributor Author

erobhal commented Aug 22, 2022

@bastelfreak Have included acceptance test now. I hope I figured it out. Looks ok in the testlogs as far as I can tell.

@bastelfreak
Copy link
Member

thanks for the work!

@bastelfreak bastelfreak merged commit 3855255 into voxpupuli:master Aug 22, 2022
@erobhal erobhal deleted the plus_auto_map branch August 23, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants