Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax dependencies version requirements #196

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Relax dependencies version requirements #196

merged 2 commits into from
Jun 14, 2023

Conversation

smortex
Copy link
Member

@smortex smortex commented Jun 11, 2023

  • Allow puppetlabs-stdlib 10.x
  • Allow puppetlabs-concat 8.x

@smortex smortex added the enhancement New feature or request label Jun 11, 2023
@smortex
Copy link
Member Author

smortex commented Jun 11, 2023 •
edited
Loading

I just realized that puppetlabs has not yet released its module that depend on stdlib to make them compatible with the latest stdlib (e.g. concat). This can result in failures to run our CI if stdlib 9.0 is installed and then the system wants to install concat but no version supporting the installed version of stdlib is available.

I think we should postpone this until Puppetlabs release its modules with updated dependencies.

@smortex smortex changed the title Update dependencies Relax dependencies version requirements Jun 14, 2023
@smortex
Copy link
Member Author

smortex commented Jun 14, 2023

Some puppetlabs modules are still not updated (e.g. inifile), but most of them are, so I think it is safe now to start relaxing version requirements of dependencies. I am removing the "Draft" status.

@smortex smortex marked this pull request as ready for review June 14, 2023 20:07
@smortex smortex merged commit 837dc55 into master Jun 14, 2023
10 checks passed
@smortex smortex deleted the update-dependencies branch June 14, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenyon kenyon kenyon approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smortex @kenyon @bastelfreak