Quote and escape special chars in mapping fs #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a mapping key could not include spaces because of the data type. Some implementations of autofs do support such keys when they are properly quoted so do not limit their use with the module and properly quote the key when it has special characters. These chars still need to be manualy espaced when used with the fs parameter because it is managed as a single String. This will be addressed in a follow-up commit as it will be a breaking change.
Multiple filesystems can be provided for a mapping by separating them with spaces. Some implementations of autofs do support spaces in path if proper quoting is in place. When managing a filesystems with spaces in its path, the end-user of the module was responsible for the correct quoting because the module interface only accept a single string for the "raw" value. Change the data type of the parameter to accept either a `String` (single filesystem) or an `Array[String]` (multiple filesystems) and transfer the responsibility of escaping to the module. This is a breaking change that may affect some users: 1. Users of mapping with multiple filesystems will need to split their `fs` parameter to provide an array of filesystems; 2. Users of mappings with quoted special chars will have to remove the quoting to avoid double-quoting.
kenyon
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple filesystems can be provided for a mapping by separating them
with spaces. Some implementations of autofs do support spaces in path
if proper quoting is in place.
When managing a filesystems with spaces in its path, the end-user of
the module was responsible for the correct quoting because the module
interface only accept a single string for the "raw" value.
Change the data type of the parameter to accept either a
String(single filesystem) or an
Array[String](multiple filesystems) andtransfer the responsibility of escaping to the module.
This is a breaking change that may affect some users:
fsparameter to provide an array of filesystems;quoting to avoid double-quoting.