Let autofs::mount mount option default to title.
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhollinger
requested changes
Jun 15, 2017
manifests/mount.pp
Outdated
| @@ -20,7 +20,7 @@ | |||
| # order => 01 | |||
| # } | |||
| # | |||
| # @param mount Location where you will mount the remote NFS Share. | |||
| # @param mount Location where you will mount the remote NFS Share. Defaults to the title. | |||
There was a problem hiding this comment.
A default doesn't need to specified in a Puppet Strings @param tag as string is able to look up the defaults on its own
A little nitpicky, but it's nice to keep things consistent across module docs.
There was a problem hiding this comment.
Corrected, I should actually read the puppet-doc docs one day.
|
@traylenator can you rebase this? |
|
I'll rebase after #65 if that's okay as it will need redoing again then. |
|
rebased |
```puppet
autofs::mount{'data':
mount => '/data',
mapfile => '/etc/auto.data',
...
}
```
can now be specified as
```puppet
autofs::mount{'/data':
mapfile => '/etc/auto.data',
...
}
```
Given the mount point has to be a unique key in the `/etc/auto.master`
anyway this makes sense.
Backwards compatible anyway of course.
dhollinger
approved these changes
Jun 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can now be specified as
Given the mount point has to be a unique key in the
/etc/auto.masteranyway this makes sense.
Backwards compatible anyway of course.