Support map types in auto.master #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhollinger
requested changes
Jun 15, 2017
README.md
Outdated
|
|
||
| This Mapping describes the name and path of the autofs map file. | ||
| This mapping is used in the auto.master generation, as well as generating the map | ||
| file from the auto.map.erb template. This parameter is no longer required. | ||
| When anything other than a simle file path isused `mapfile_manage` must be false. |
There was a problem hiding this comment.
Two corrections there.
| @@ -42,7 +51,7 @@ | |||
| define autofs::mount ( | |||
| Stdlib::Absolutepath $mount, | |||
| Integer $order, | |||
| Optional[Stdlib::Absolutepath] $mapfile = undef, | |||
| Optional[Variant[Stdlib::Absolutepath,Autofs::Mapentry]] $mapfile = undef, | |||
There was a problem hiding this comment.
Should we add some logic here to to fail if type($mapfile) == Autofs::Mapentry && $mapfile_manage == true?
I'm guessing on the syntax, but I could see that being a good idea.
Thoughts?
There was a problem hiding this comment.
Good idea $mapfile.is_a(Autofs::Mapentry) is the magic.
|
@traylenator could you look into why the travis tests are failing as well? Thanks! |
It is desirable to be able to configure map types.
/smb program:/etc/auto.smb
```puppet
mount{'smb':
mount => '/smb',
mapfile => 'program:/etc/auto.smb',
mapfile_manage => false,
}
```
|
Failing tests was just somthing transient unrelated. |
dhollinger
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is desirable to be able to configure map types.
/smb program:/etc/auto.smb