Confine autofs_version fact to Linux kernel. #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgreen210
force-pushed
the
issue_68_autofs_version
branch
from
f2ac238
to
b7eccde
Compare
|
Closing this PR since still get an error: I can look at this some more next week. |
|
Reopening the PR - the changes do work. It looks like librarian-puppet doesn't handle moving between puppet forge and git nicely, so I wasn't testing the right version of the code on Friday. |
traylenator
approved these changes
Jun 19, 2017
alexjfisher
reviewed
Jun 19, 2017
| @@ -1,4 +1,5 @@ | |||
| Facter.add(:autofs_version) do | |||
| confine kernel: 'Linux' | |||
There was a problem hiding this comment.
Solaris (an OS this module provides some support for) doesn't support automount -V either.
afisher@solaris:~$ automount -V
automount: illegal option -- V
automount: Usage: automount [ -v ] [ -t duration ]
|
Thanks @jgreen210 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68
#68