Remove unused template #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh! Let's drop it. I think this would have been added to have a job to backup the catalog. I've never hit the situation where I needed to have a catalog job specifically, but I think the Bacula project recommends it. I've moved directors and databases many times in the last few years without ever needing to rely on this functionality, mostly because I have good database backups. Anyway, if the idea ever comes up again, we can re-implement. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While converting ERB files to EPP, I found what seems to be an unused template.
I am not sure if it is better to keep this template and convert it to epp so that users who want to have a custom template can use it to get inspired, or simply drop it? Maybe moving this to the documentation may make sense?
It seems to be very specific to some particular configuration…
Please tell me what you think about it!