Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to not include the director defaults #132

Merged
merged 4 commits into from Dec 22, 2018

Conversation

tcassaert
Copy link

This pull request adds a simple boolean to be able to not provision the default jobdefs, schedule, pool, ...

@jflorian
Copy link
Contributor

jflorian commented Dec 3, 2018

I like the enhancement conceptually. However, I think it might be helpful to rename the parameter to something like manage_defaults simply because include has a strong association with Bacula's FileSets. Also, having the corresponding docs updated would be nice.

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think this is a good idea. LGTM

@smortex smortex requested a review from zachfi December 17, 2018 22:16
@zachfi
Copy link
Contributor

zachfi commented Dec 22, 2018

Looks good, thanks for the PR.

@zachfi zachfi merged commit e3020b5 into voxpupuli:master Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants