Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the namespaced function postgresql::postgresql_password() #186

Merged
merged 2 commits into from Jun 28, 2023

Conversation

smortex
Copy link
Member

@smortex smortex commented Jun 28, 2023

postgresql_password() is deprecated, swith to the namespaced version
introduced in puppetlab-postgresql 6.4.0.
@smortex smortex marked this pull request as ready for review June 28, 2023 21:20
@smortex smortex changed the title Use the namespaced function postgresql::postgresql_password() Use the namespaced function postgresql::postgresql_password() Jun 28, 2023
@alexjfisher
Copy link
Member

I don't think I'd go as far as marking this backwards-incompatible. IMO, it's probably fine to just bump the postgresql dependency in the metadata as you've done. This briefly came up on irc/slack the other day and IIRC @ekohl also took this position?? (If you look for them, I think you'll find plenty of other examples where we've not done a major release just because we required a newer version of a dependency)

@smortex
Copy link
Member Author

smortex commented Jun 28, 2023

I was thinking about it and as the next version in a major one, I decided that it was okay to mark it backwards-incompatible even if I truly believe nobody will be affected by this minimum version bump. I'll remove the label so that it still appears as "merged pull requests" in the changelog but without the emphasis it probably does not need.

@smortex smortex merged commit 9f1542d into master Jun 28, 2023
4 checks passed
@smortex smortex deleted the namespaced-postgresql_password branch June 28, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants