Remove oauth username/password login #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method for logging in to the Forge API is unsupported and not guaranteed to remain stable. We should instruct users to generte an API key instead.
bastelfreak
changed the title
bastelfreak
force-pushed
the
remove_username_password
branch
from
cf7e9d5
to
51b25ad
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #119 +/- ##
==========================================
- Coverage 48.38% 47.13% -1.26%
==========================================
Files 8 8
Lines 465 454 -11
==========================================
- Hits 225 214 -11
Misses 240 240
☔ View full report in Codecov by Sentry. |
bastelfreak
force-pushed
the
remove_username_password
branch
from
51b25ad
to
a02e644
Compare
ekohl
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a resubmission of #104