Skip to content
This repository has been archived by the owner on Apr 28, 2023. It is now read-only.

Commit

Permalink
Merge pull request #28 from lukebigum/master
Browse files Browse the repository at this point in the history
Fixing error message and adding spec test
  • Loading branch information
bastelfreak committed Sep 15, 2017
2 parents 76fef51 + ef92a83 commit 0276c70
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/puppet_x/util/boolean.rb
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def munge(v)
elsif false_values.include? v
false
else
raise ArgumentError, "Value '#{value}':#{value.class} cannot be determined as a boolean value"
raise ArgumentError, "Value '#{v}':#{v.class} cannot be determined as a boolean value"
end
end
end
Expand Down
5 changes: 4 additions & 1 deletion spec/unit/puppet/property/boolean_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
subject.munge(arg).should == true
end
end
[false, :false, 'false', :no, 'no', :undef, nil].each do |arg|
[:absent, false, :false, 'false', :no, 'no', :undef, nil].each do |arg|
it "should munge #{arg.inspect} as false" do
subject.munge(arg).should == false
end
Expand All @@ -21,4 +21,7 @@
expect { subject.munge(arg) }.to raise_error ArgumentError
end
end
it "fail to munge 'woof' with a specific message" do
expect { subject.munge('woof') }.to raise_error ArgumentError, %r{Value 'woof':String cannot be determined as a boolean value}
end
end

0 comments on commit 0276c70

Please sign in to comment.