Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for snapshots using pre/post scripts; replace --numeric-owner with --numeric-ids #150

Merged
merged 3 commits into from Apr 7, 2022

Conversation

hashworks
Copy link
Member

@hashworks hashworks commented Apr 2, 2022

Snapshots should be created using pre_backup_script and cleaned up with post_backup_script. Additionally, the source_paths paths should be adjusted to match the snapshot mount point.

Example:

pre_backup_script => "mkdir -p /snapshots && btrfs subvolume snapshot -r / /snapshots/borg-backup",
post_backup_script => "btrfs subvolume delete /snapshots/borg-backup",
source_paths => ["."],

@hashworks hashworks force-pushed the feature/SnapshotSupport branch 8 times, most recently from 1bce2e1 to cc16bb0 Compare April 2, 2022 18:06
@hashworks
Copy link
Member Author

@bastelfreak Any ideas why some test suits are failing?

@hashworks hashworks changed the title WIP: Add support for snapshots using pre/post scripts Add support for snapshots using pre/post scripts Apr 2, 2022
@bastelfreak bastelfreak added the enhancement New feature or request label Apr 7, 2022
manifests/init.pp Outdated Show resolved Hide resolved
@hashworks hashworks force-pushed the feature/SnapshotSupport branch 2 times, most recently from dfefe00 to eb0bb24 Compare April 7, 2022 18:28
@bastelfreak bastelfreak added backwards-incompatible and removed enhancement New feature or request labels Apr 7, 2022
Since the backup script is a template anyway it is unecessary to split
move some configuration to additional files.
`--numeric-owner` is deprecated and replaced by `--numeric-ids`.

See https://git.server-speed.net/users/flo/bin/tree/backup.sh
Snapshots should be created using `pre_backup_script` and cleaned up
with `post_backup_script`. The `source_paths` should be adjusted to
match the snapshot mount point.
@bastelfreak bastelfreak merged commit a7cc861 into master Apr 7, 2022
@bastelfreak bastelfreak deleted the feature/SnapshotSupport branch April 7, 2022 18:40
@bastelfreak bastelfreak changed the title Add support for snapshots using pre/post scripts Add support for snapshots using pre/post scripts; replace --numeric-owner with --numeric-ids Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants