Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't format Floats as Strings #54

Merged
merged 1 commit into from Jun 8, 2022
Merged

Don't format Floats as Strings #54

merged 1 commit into from Jun 8, 2022

Conversation

alexjfisher
Copy link
Member

Previously if the only change in a class was a parameter's data type
from a Float to a String, then the class resource would be marked as
different, but str_diff would return nil causing a Error: undefined method split' for nil:NilClass error here

Fixes #32

@alexjfisher
Don't format Floats as Strings
c7f6b1a 
Previously if the only change in a class was a parameter's data type
from a `Float` to a `String`, then the class resource would be marked as
different, but
[str_diff](https://github.com/camptocamp/puppet-catalog-diff/blob/b7f3031e380502eb6154242b1710b9ab7c105b42/lib/puppet/catalog-diff/comparer.rb#L130)
would return `nil` causing a `Error: undefined method split' for nil:NilClass` error
[here](https://github.com/camptocamp/puppet-catalog-diff/blob/b7f3031e380502eb6154242b1710b9ab7c105b42/lib/puppet/catalog-diff/comparer.rb#L60)

Fixes voxpupuli#32
@stale
Copy link

stale bot commented Mar 15, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 15, 2022
@alexjfisher
Copy link
Member Author

Dear stale bot. This is actually a fairly trivial PR that fixes an actual issue. Labeling it wontfix is not helpful IMO.

@stale stale bot removed the wontfix This will not be worked on label Mar 15, 2022
DLeich
DLeich approved these changes Mar 17, 2022
View reviewed changes
Copy link

@DLeich DLeich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stale
Copy link

stale bot commented May 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 25, 2022
@DLeich
Copy link

DLeich commented May 26, 2022

This is a legit fix. Hopefully someone will merge it soon so stale bot won't strike again!

@stale stale bot removed the wontfix This will not be worked on label May 26, 2022
@alexjfisher
Copy link
Member Author

@bastelfreak Have you got any update on any migration plans?

@bastelfreak
Copy link
Member

I am waiting for feedback in #60

@alexjfisher
Copy link
Member Author

@bastelfreak Would you like to merge this one now?

@SimonHoenscheid
Copy link
Sponsor Member

@alexjfisher Migration Done.

@alexjfisher
Copy link
Member Author

@alexjfisher Migration Done.

Yep. Just noticed. Didn't want to merge my own PR though.

@bastelfreak bastelfreak added bugfix Something isn't working bug Something isn't working and removed bugfix Something isn't working labels Jun 8, 2022
@bastelfreak bastelfreak merged commit d9cebbf into voxpupuli:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DLeich DLeich DLeich approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: undefined method split' for nil:NilClass when using --show_resource_diff`
4 participants
@alexjfisher @DLeich @bastelfreak @SimonHoenscheid