Merge pull request #572 from matejzero/Interface-ReportInactive

Add support for Interface plugin option ReportInactive

manifests/plugin/interface.pp

@@ -3,13 +3,17 @@
   $ensure         = 'present',
   $interfaces     = [],
   $ignoreselected = false,
+  $reportinactive = true,
   $interval       = undef,
 ) {
 
   include ::collectd
 
   validate_array($interfaces)
-  validate_bool($ignoreselected)
+  validate_bool(
+    $ignoreselected,
+    $reportinactive,
+  )
 
   collectd::plugin { 'interface':
     ensure   => $ensure,

spec/classes/collectd_plugin_interface_spec.rb

@@ -38,4 +38,23 @@
       is_expected.to compile.and_raise_error(%r{String})
     end
   end
+
+  context 'interface options should be set with collectd 5.6' do
+    let :facts do
+      {
+        osfamily: 'RedHat',
+        collectd_version: '5.6.0',
+        operatingsystemmajrelease: '7'
+      }
+    end
+    let :params do
+      {
+        reportinactive: true
+      }
+    end
+
+    it 'Will include ValuesPercentage in /etc/collectd.d/10-interface.conf' do
+      should contain_file('interface.load').with_content(%r{ReportInactive true})
+    end
+  end
 end

templates/plugin/interface.conf.erb

@@ -3,4 +3,7 @@
   Interface  "<%=interface %>"
 <% end -%>
   IgnoreSelected <%= @ignoreselected %>
+<% if scope.lookupvar('collectd::collectd_version_real') and scope.function_versioncmp([scope.lookupvar('collectd::collectd_version_real'), '5.6']) >= 0 -%>
+  ReportInactive <%= @reportinactive %>
+<% end -%>
 </Plugin>